Skip to content

chore(atomic): migrate atomic-insight-history-toggle to Lit #6849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexprudhomme merged 15 commits into from
Jan 14, 2026
Merged

chore(atomic): migrate atomic-insight-history-toggle to Lit #6849

alexprudhomme merged 15 commits into from
Jan 14, 2026

Conversation

Copy link
Contributor

Copilot AI commented Dec 19, 2025 •
edited by alexprudhomme
Loading

✅ Checklist

  • 🧪 The component is unit tested
  • 🧪 The component includes E2E tests
  • 🗑️ Old Cypress tests exclusive to the component are removed
  • 📖 The component is documented in storybook with an .mdx file
  • ♿ The component complies with the Web Content Accessibility Guidelines.
  • 🌐 All strings intended for humans or assistive technology must be localized with i18n.
  • 📦 The Lit component is exported in the appropriate index.ts and lazy-index.ts files.
  • 🎨 CSS parts are documented still accessible.
  • 🦥 Slotted Content, public methods and properties are documented
  • 🔄 The component outputs the same Angular output as before with Stencil
  • 🏷️ The component declares the component type in the HTMLElementTagNameMap

https://coveord.atlassian.net/browse/KIT-4875

Copilot AI changed the title [WIP] Migrate atomic-insight-history-toggle component to Lit feat(atomic): migrate atomic-insight-history-toggle to Lit Dec 19, 2025
Copilot AI requested a review from alexprudhomme December 19, 2025 16:32
@alexprudhomme alexprudhomme changed the title feat(atomic): migrate atomic-insight-history-toggle to Lit chore(atomic): migrate atomic-insight-history-toggle to Lit Dec 19, 2025
SimonMilord
SimonMilord approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

erocheleau
erocheleau requested changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the rule with internal components now?

This is like a dummy button we've added only to be used in the Hosted Insight Panel Builder.

erocheleau
erocheleau approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
I'm assuming this will be the pattern? Without tests, and documentation mentions it's internal?

@alexprudhomme alexprudhomme added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit f89c113 Jan 14, 2026
98 checks passed
@alexprudhomme alexprudhomme deleted the copilot/migrate-atomic-insight-component branch January 14, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@erocheleau erocheleau erocheleau approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@SimonMilord SimonMilord SimonMilord approved these changes

@alexprudhomme alexprudhomme Awaiting requested review from alexprudhomme

@lavoiesl lavoiesl Awaiting requested review from lavoiesl lavoiesl was automatically assigned from coveo/dxui

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar was automatically assigned from coveo/dxui

Assignees

@alexprudhomme alexprudhomme

Copilot code review Copilot

Labels

chromatic Opt-in w/ Chromatic cross-team This PR is a collaboration between multiple teams high-confidence The author of the PR author has high confidence that it is correct. It should be ready to merge. new-lit-component

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erocheleau @louis-bompart @SimonMilord @alexprudhomme